6468-docs-and-harmonize

check_haproxy_health

@@ -73,13 +73,15 @@ esac
 
 ph.require wget
 
-cat $HAPROXYcfgfile >/dev/null
-if [ $? -ne 0 ]; then
+if [ ! -f $HAPROXYcfgfile ]; then
+  ph.abort "UNKNOWN: config file does not exist: $HAPROXYcfgfile"
+fi
+
+if ! cat $HAPROXYcfgfile >/dev/null 2>&1; then
   ph.abort "UNKNOWN: unable to read ha proxy config $HAPROXYcfgfile ... $(ls -l $HAPROXYcfgfile)"
 fi
 
-cat $HAPROXYcfgfile | grep " mode .*http" >/dev/null
-if [ $? -ne 0 ]; then
+if ! cat $HAPROXYcfgfile | grep " mode .*http" >/dev/null; then
   ph.abort "UNKNOWN: haproxy is not in http mode"
 fi